So there is no secret that our Armory module has been buggy as hell. To add to my immeasurable annoyance, whatever breaks it, seems to random as hell, thus I can't really see what exactly leads to the infamous blank squares and stuff. To add to it, the code for our Armory module became so cluttered and inconsistent, that we can barely read it and remember what was actually happening and what followed what. Sometimes this resulted in one little change that was suppose to move a text line 3 pixels higher was just throwing elements all over the place.
There is no secret that the armory module was made by Arstraea and ported to S&L by Repooc with the help of Arstraea with very little alterations from the original. Arstraea's style of coding is radically different from ours, thus reading it can be hard for us (if not drunk enough). After the years of updating and trying to fix everything that kept popping up, it became some patched up monster just thrown together. So rewriting everything with our style of coding will make it easier for us not only to update it but also to troubleshoot when something comes up, while keeping the general look and feel of what it should be.
We are pretty happy with how character/inspect screen looked overall, thus the basic layout should stay the same or at least very similar. Currently we "hide" blizzards character and inspect frames and make our own which duplicates everything for no reason. By duplicating a lot of the stuff required additional tooltip scanning and server requests. Some requests failed or glitched because of server throttling which messed up our gear cache, making the whole thing rebuild itself with no server data available. Frankly, doing that was not an ideal way. Considering all the data that was needed was already loaded and ready to be used, because the default frame was right under ours duh. So current plan is to just use that instead of dropping more requests => more throttling.
So for the sake of my sanity (Who cares about Repooc's? Not me!), I want to get rid of as many bugs as possible by scrapping the current armory module and just rebuild it from scratch. This should make it easier to support and stop those random, annoying, issues (in theory).
This outlines the current plan we have for this module.
- Keep the looks as is
- Get rid of unnecessary frames
- Less unnecessary info calls
- Keeping the code as simple as possible
This rewrite will take place in it's own branch in our repository hosted here at Tukui.org and will not affect any releases for the retail version. So if something critical comes up, we wouldn't need to wait until the new armory is ready to go. Some time next week we should have a stable and relatively feature complete revision for everyone willing to give it a spin and tell us if new code opens a rift in reality or something. Meanwhile if you have any ideas or requests for the new armory, you can post here.
Most of the things are in the working state. Couple of information points.
- Inspect can't show you actual essences tooltips, due to blizz not providing info about other classes essences.
- Missing warnings are not in yet, planning to change their looks at a later date.
- DB conversion is not ready yet, so that will basically reset Armory to its default state. I'm thinking about just not converting old settings at all
- Stats list alterations are not in yet
- Inspect tabs are default for now
- You may experience some weird sizing issues for reputation tab on character frame